On Mon, 28 Feb 2022 23:27:50 GMT, DamonGuy <[email protected]> wrote:
>> Html does not fit in JButton at certain sizes because default Insets cause
>> html to be displayed off-center.
>>
>> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable
>> clipping if html does not fit, similar to regular text. AquaButtonUI.java
>> now detects when html does not fit, and an implementation for alternate
>> insets that are recursively tested for regular text inside
>> layoutAndGetText() are now also being used for html content.
>>
>> Created test (Bug8015854.java) with the same format as the test described on
>> the issue. The button is of size 37x37 with an image of a red square sized
>> 19x19. The test checks for red pixels on the edges of where the square image
>> should be from the center of the button. The test fails with the non-changed
>> jdk, but passes with the changes.
>
> DamonGuy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated code organization. Removed unnecessary catch blocks and comments.
> Added null check for frame disposal.
test/jdk/javax/swing/JButton/HtmlButtonImageTest/HtmlButtonImageTest.java line
53:
> 51: public final class HtmlButtonImageTest {
> 52: private static JFrame frame;
> 53: private static Point point;
`point` must be volatile as it's accessed from two threads.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7310
