On Sat, 5 Mar 2022 01:56:04 GMT, Alisen Chung <ach...@openjdk.org> wrote:
> > Can you explain (walk through) why the old code was wrong and the new code > > is correct ? There's a lot of things that aren't obvious to me. The old > > code would use the same coords and just toggle which parts were in > > highlight/shadow Now you've spilit is so that lowered does things in a > > different order and so forth and I find it impossible without an > > explanation of your reasoning to say if that reasoning is correct ... > > Also the bug report deserves an evaluation. > > I think currently the problem is the lighter color is overdrawing the darker > color, so I swapped the drawing order so that the darker color is always > drawn second. I think the reason the rect and lines are drawn at the same x > value probably has to do with the affine transform in the graphics object, > but I'm not sure why it happens. Is it possible that in the new order the darker colour is drawn over the lighter one? ------------- PR: https://git.openjdk.java.net/jdk/pull/7449
