On Thu, 10 Mar 2022 11:22:15 GMT, Maxim Kartashev <d...@openjdk.java.net> wrote:
>> Maxim Kartashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> HiDPIRobotScreenCaptureTest.java: smaller frame size such that it fits on >> a 1200x600 screen. >> >> ScreenCaptureGtkTest.java: smaller frame size; added code to save >> the image on failure. > > The initial reason for `ScreenCaptureGtkTest` failure was that on Linux the > window was *sometimes* positioned such that some of the pixels targeted by > `Robot` couldn't be pointed to by the underlying GTK API. So these failures > were intermittent and out of control of the test itself; change of the > windows' size could've simply changed the window manager's logic for position > calculation and thus accidentally made the test pass. @mkartashev The test results are good. > The initial reason for ScreenCaptureGtkTest failure was that on Linux the > window was sometimes positioned such that some of the pixels targeted by > Robot couldn't be pointed to by the underlying GTK API. So these failures > were intermittent and out of control of the test itself; change of the > windows' size could've simply changed the window manager's logic for position > calculation and thus accidentally made the test pass. I see, thank you for clarification. ------------- PR: https://git.openjdk.java.net/jdk/pull/7613
