On Fri, 11 Mar 2022 14:38:28 GMT, Srinivas Mandalika <smandal...@openjdk.org> wrote:
>> Create a regression test for CCC8000326 >> >> Issue is identified by >> [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which >> identifies that after focus moves into JMenuBar, whose focus traversal key >> is disabled by default, it never moves to other focusable component. >> >> By default, pressing the Tab key does not transfer focus from a JMenuBar >> which is added to a container together with other Swing components, because >> the focusTraversalKeysEnabled property of JMenuBar is set to false. To >> resolve this, you should call the >> JMenuBar.setFocusTraversalKeysEnabled(true) method. >> >> The test verifies focus traversal for the above described scenario. >> This review is for migrating tests from a closed test suite to open. > > Srinivas Mandalika has updated the pull request incrementally with one > additional commit since the last revision: > > Added @bug keyword Changes requested by aivanov (Reviewer). test/jdk/java/awt/Focus/8000326/SetFocusTraversalKeysEnabledTest.java line 64: > 62: SwingUtilities.invokeAndWait(() -> { > 63: currentFocusOwner = jFrame.getFocusOwner(); > 64: }); When there's only one statement in the lambda statement, it can be replaced with expression lambda: Suggestion: SwingUtilities.invokeAndWait(() -> currentFocusOwner = jFrame.getFocusOwner()); Just like you did for `createGUI()`. This also applies to `jFrame.dispose()` statement. ------------- PR: https://git.openjdk.java.net/jdk/pull/7512
