On Tue, 22 Mar 2022 06:45:23 GMT, Tejesh R <d...@openjdk.java.net> wrote:
>> Removed the println() line from the Interrupted catch block. Since
>> waitForID() Interrupt indicates completion of Image Loading, println as
>> Interrupt handling was not required.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Changes requested by aivanov (Reviewer).
src/java.desktop/share/classes/javax/swing/ImageIcon.java line 324:
> 322: protected void loadImage(Image image) {
> 323: MediaTracker mTracker = getTracker();
> 324: Boolean bIsInterrupted = false;
Why do you use object wrapper instead of the primitive `boolean` type?
In Java, you don't add type prefixes to variable names; `bIsInterrupted` should
be `interrupted`.
src/java.desktop/share/classes/javax/swing/ImageIcon.java line 341:
> 339: {
> 340: loadStatus = MediaTracker.ABORTED;
> 341: }
Did you compile this code?
I can't see `interrupted` variable being declared.
Please follow Java Coding Style: a space between `if` and the opening
parenthesis, the opening brace is on the same line rather than on its own line.
The code that [I posted as a
sample](https://github.com/openjdk/jdk/pull/7754#discussion_r831096445) follows
the Java Style.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7754
