On Wed, 16 Mar 2022 06:02:28 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced >> Gulim korean font so it needs to be updated to show korean fonts > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > korean fallback added As I mentioned initially, > tested with sanserif, serif, monospaced, dialog, dialoginput with PLAIN, > BOLD, ITALIC, BOLD-ITALIC style **in that order** so 1st 4 are sansserif, next 4 are serif etc. As I see, we have this font support in the fontconfig properties Serif = Batang batang.ttc sansserif = Malgun Gothic malgun.ttf monospaced = Gulimche gulim.ttc dialog = Malgun Gothic malgun.ttf dialoginput = Gulim gulim.ttf Now in my WIndows 10, I have these font files irrespective of Korean font pack installed or not, so I guess that is why there is **no difference** in the font image with the fix with/without korean font pack Now, without the fix, [comparing with/without the fix with Korean font pack installed https://github.com/openjdk/jdk/pull/7643#issuecomment-1070307750 and https://github.com/openjdk/jdk/pull/7643#issuecomment-1070348395 ] there is minor difference (AFICS) in bold, italic corresponds to sansserif (2-3 position), monospaced (10-11), dialog (14-15), dialoginput (18-19) which used Gulim before fix but used Malgun Gothic Bold with fix **which i guess is expected**.. Also, there is clear difference in 6-8 th position for Bold, Italic, Bold-Italic which corresponds to **serif font** which uses same Batang font before and after the fix which I guess is because of the "first form", "second form" fallback issue discusses in this thread . I think with the fix `allfont.korean-fallback` is in effect so it uses malgun (which is why 1-4 position looks same as 5.-8) and without fix, it uses Batang ------------- PR: https://git.openjdk.java.net/jdk/pull/7643
