On Tue, 29 Mar 2022 08:04:42 GMT, Srinivas Mandalika <smandal...@openjdk.org> wrote:
> Write an automated regression test for JDK-4670319 > > Issue > When a JTree node is expanded or collapsed, an Accessibility PropertyChange > event is fired with the old state of "collapsed" and new state of "expanded" > (or vice versa). The problem is that the source of the event is the > AccessibeJTree, and not the AccessibleJTreeNode. This means that an assistive > technology listening to this event is unable to report to the user what node > was expanded/collapsed. > > Fix > Fix for [JDK-4670319](https://bugs.openjdk.java.net/browse/JDK-4670319) > addresses the above issue. When tree node is expanded/collapsed, > PropertyChangeEventSource is the Node. > This review is for a test for validating the above issue. > > This review is for migrating tests from a closed test suite to open. > > Testing: > The test ran successfully on Mach5 with multiple runs (30) on windows-x64, > linux-x64 and macos-x64. test/jdk/javax/accessibility/4670319/AccessibleJTrePCESourceTest.java line 28: > 26: * @key headful > 27: * @bug 4670319 > 28: * @summary AccessibleJTree should fire a PropertyChangeEvent using a > AccessibleJTreeNode as source. Please split the long lines, use the 80 chars per line. test/jdk/javax/accessibility/4670319/AccessibleJTrePCESourceTest.java line 50: > 48: SwingUtilities.invokeAndWait(() -> createGUI()); > 49: Robot robot = new Robot(); > 50: robot.setAutoDelay(500); Are you sure that the autodelay is needed here? The test does not use any method other than `waitForIdle` ------------- PR: https://git.openjdk.java.net/jdk/pull/8012
