On Mon, 28 Mar 2022 15:53:04 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   scale stroke width at higher scalings
>
> test/jdk/java/awt/TitledBorder/TitledBorderTest.java line 46:
> 
>> 44:  * @bug 8279614
>> 45:  * @summary The left line of the TitledBorder is not painted on 150 
>> scale factor
>> 46:  * @requires (os.family == "windows")
> 
> The test is not Windows specific, is it? Yet Java supports fractional scales 
> on Windows only at the moment, right?
> 
> I still think it makes sense to run the test on Linux and macOS for 100%, 
> 200% and 300% which are supported.

Well the test is setting the Windows L&F, and evaluating its rendering.
Which seems to me to make it windows-specific, as written.
The test would would need to run through all the L&Fs if it is actually valid 
to do so.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7449

Reply via email to