On Mon, 4 Apr 2022 18:59:39 GMT, Phil Race <[email protected]> wrote:
>> lawrence.andrews has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Dispose the Frame based in EDT
>
> test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java line 74:
>
>> 72: f.setLocationRelativeTo(null);
>> 73: f.setVisible(true);
>> 74: });
>
> I don't see where/how this frame is disposed.
Added code to dispose the test UI.
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 76:
>
>> 74: this.timeoutMinutes = timeoutMinutes;
>> 75:
>> 76: invokeAndWait(() -> {
>
> This should also be preceded by a check as to whether it is EDT - I thought I
> suggested something along those lines already - make it so it works either
> way and the test itself doesn't have to care to make sure it is on or off
> EDT, and also even it if uses invokeAndWait when it didn't need to it is
> harmless.
Added a check whether the method is called with in EDT else invoke the UI with
in EDT.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7966
