On Fri, 8 Apr 2022 07:08:25 GMT, Manukumar V S <m...@openjdk.org> wrote:
>> Write an automated regression test for >> [JDK-4371575](https://bugs.openjdk.java.net/browse/JDK-4371575) >> >> Issue: >> As part of the Merlin focus project, JComponent.setRequestFocusEnabled was >> deprecated and its implementation was changed to map exactly to the new >> method Component.setFocusable. Scott believes that the old behavior may be >> preferable. He would like to be able to specify that a Component is >> focusable, >> and should receive focus during keyboard traversal, but that it should not >> automatically take focus when the user clicks on it with the mouse. >> >> We are concerned that the accessibility team would be against this behavior, >> and this also seems like more of a PLAF issue. Nevertheless, we should look >> into it before beta ships. >> >> Fix: >> After some discussion we decided that the best balance of the old and new >> would be to make this an advisory property. This property will not be >> synonymous with focusable. Instead our mouse listeners will check this >> property before requesting focus. This provides as closely as possible the >> old behavior, while allowing people to use the new focusable property if >> they don't want a component focusable at all. >> >> Testing: >> Tested in mach5, 10 times with all the 3 available platform like macosx, >> windows and linux and got all Pass. > > Manukumar V S has updated the pull request incrementally with one additional > commit since the last revision: > > Review comment fixed: Removed unwanted directory Marked as reviewed by prr (Reviewer). test/jdk/javax/swing/JComponent/JComponentSetRequestFocusEnabledTest.java line 76: > 74: } > 75: robot.waitForIdle(); > 76: Since you specified robot.setAutoWaitForIdle(true) I wonder if this is needed ? Shouldn't do any harm though. ------------- PR: https://git.openjdk.java.net/jdk/pull/8143
