On Thu, 7 Apr 2022 15:09:27 GMT, lawrence.andrews <d...@openjdk.java.net> wrote:
>> We need a common manual test framework code that can be shared across all
>> the client manual test. This framework class should have the following
>> 1) Frame which contains test instruction .
>> 2) Pass & Fail button so that user can mark the test pass or fail
>> 3) Upon failing the test user should be able to elaborate why the test
>> failed and this can be added to the test failure.
>> 4) Disposing of all the frames.
>>
>> @aivanov-jdk
>
> lawrence.andrews has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8284535 : Fix PrintLatinCJKTest.java test that is failing with Parse
> Exception
test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 52:
> 50: private final static CountDownLatch latch = new CountDownLatch(1);
> 51: private static volatile boolean failed = false;
> 52: private static volatile boolean timeout = false;
`false` is the default value, so you can skip assigning `false`.
test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 198:
> 196: * well as the frame that is added via addTestFrame(Frame frame)
> 197: */
> 198: private static void disposeFrames() {
It should be `synchronized` to prevent access to `frameList` from another
thread while it's being iterated.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7966
