On Sun, 10 Apr 2022 06:12:26 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> The test was failing on macos and was excluded in macos because the 
>> viewposition was not changed after mouse wheel scroll. Seems like mouse 
>> wheel scroll direction is opposite in macos compared to windows etc so if we 
>> try to down-wheel scroll in macos when view position is at center of 
>> viewport (say element 3 is selected out of visible 7 elements), it cannot 
>> change viewposition as it cannot "scroll up" (since we are already at 
>> topmost viewport) whereas in windows, when we do down-wheel scroll in mouse 
>> wheel, it "scroll down" the viewport so viewposition is changed.
>> 
>> Fix is to use opposite scrolling motion in macos to check mouse wheel scroll 
>> is happening, which is what the testcase is meant for. CI testing of this 
>> test on all platform is ok.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Check mousewheel rotation direction at runtime

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8123

Reply via email to