On Tue, 5 Apr 2022 17:30:31 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> test/jdk/javax/swing/ImageIcon/LoadInterruptTest.java line 74:
>> 
>>> 72: 
>>> 73:         Thread.currentThread().interrupt();
>>> 74:         ImageIcon i = new 
>>> ImageIcon("https://openjdk.java.net/images/openjdk.png";);
>> 
>> This is just asking for trouble. Test machines which can't access that URL 
>> might cause the test to behave differently than you expect.
>> Use some local image file loaded from a file: URL 
>> We have plenty you can choose from in other tests.
>
> This is intentional, it makes sure the image is in `LOADING` state to verify 
> that the newly added resets it to `ABORTED`.
> 
> I don't expect the image to load, we don't care. If it succeeds, the status 
> is `COMPLETE`; if it times outs or another error occurs, the status is 
> `ERRORED`.

ok .. I trust this test has been verified in mach5 already ..

-------------

PR: https://git.openjdk.java.net/jdk/pull/7754

Reply via email to