On Thu, 14 Apr 2022 23:45:28 GMT, lawrence.andrews <d...@openjdk.java.net>
wrote:
>> Fixed the following issue.
>> 1) Removed yes/no since test was failing due to "Parser error due to yesno
>> in @run main/manual=yesno"
>> 2) After removing yes/no test run( just shows the UI and gets dispose
>> immediately). User cannot interact with the test UI and mark the test pass
>> or failed.
>> So added Pass and Fail button to mark the test result.
>> 3) Added timeout if in case user does not interact with the test UI.
>>
>> @shurymury
>> @aivanov-jdk
>
> lawrence.andrews has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update PrintGlyphVectorTest.java
Approving since I think the minor things I pointed out aren't problems for the
test
test/jdk/java/awt/print/PrinterJob/PrintGlyphVectorTest.java line 131:
> 129: PrinterJob pj = PrinterJob.getPrinterJob();
> 130: if (pj == null || pj.getPrintService() == null) {
> 131: System.out.println("Printer not configured or available."
I realise the test was already doing the pj == null check but per. the spec,
this shouldn't happen
https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/awt/print/PrinterJob.html#getPrinterJob()
-------------
Marked as reviewed by prr (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8004
