On Wed, 13 Apr 2022 11:02:05 GMT, Srinivas Mandalika <smandal...@openjdk.org> 
wrote:

> Create an automated test for 
> [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535)
> AccessibleValue implementation only accept Integers
> The AccessibleValue implementations of the following components:
> 
> java.awt.Scrollbar
> javax.swing.AbstractButton
> javax.swing.JInternalFrame
> javax.swing.JSplitPane
> javax.swing.JScrollBar
> javax.swing.JProgressBar
> javax.swing.JSlider
> 
> require the argument to setCurrentAccessibleValue(Number) to be an Integer, 
> else they completely ignore it - it returns a false indicating that the value 
> has not been set by the return value, but they cannot know the reason for 
> that).
> 
> The test verifies that for each of the above components, the AccessibleValue 
> is set when it is set to a Number (Float, Double, long etc) and not just for 
> an Integer.
> 
> his review is for migrating tests from a closed test suite to open.
> 
> Testing:
> The test ran successfully on Mach5 with multiple runs (30) on windows-x64, 
> linux-x64 and macos-x64.

test/jdk/javax/accessibility/4422535/SetCurrentAccessibleValueTest.java line 93:

> 91:         }
> 92: 
> 93:         if (!jScrollBar.getAccessibleContext().getAccessibleValue()

maybe you could write a loop to run each component?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8220

Reply via email to