On Tue, 26 Apr 2022 05:57:32 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> Harshitha Onkar has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   added new color to CSystemColors.m - CELL_HIGHLIGHT_COLOR
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaLookAndFeel.java line 392:
> 
>> 390: 
>> 391:         // for table cell highlighter
>> 392:         final Color cellFocusRing = 
>> AquaImageFactory.getCellHighlightColorUIResource();
> 
> overall looks ok. I believe you have tested well in BigSur and Monterey also..
> Minor nit, this cellFocusRing should be "cellFocusRingColor" like other color 
> variables.

@prsadhuk Updated the PR. A note on the test case, since the test case is 
automated it tests the cell focus ring with colors loaded during the start of 
program execution and any on-the-fly accent color changes were tested manually.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7768

Reply via email to