On Wed, 20 Apr 2022 07:14:33 GMT, Manukumar V S <m...@openjdk.org> wrote:
>> Write a regression test for >> [JDK-4390885](https://bugs.openjdk.java.net/browse/JDK-4390885) Enhancement >> Request. >> >> Issue: >> Please add the ability to set the location of a JFileChooser. This might be a >> bug, but JFileChooser.setLocation() has no effect when >> JFileChooser.showXXXXDialog() is called. This is becoming very important as >> the >> popularity of multiple monitors is increasing. These dialogs show up on the >> wrong monitor which is really annoying. Also due to bug #4189244 I am unable >> to >> avoid painting problems by positioning the dialog away from the menu item >> that >> initiated it. >> >> Fix: >> Now it's possible to set the location of Dialog in JFileChooser. >> >> Testing: >> 1. Tested in Mach5 10 times per platform(macos,linux,windows) and got all >> Pass. > > Manukumar V S has updated the pull request incrementally with one additional > commit since the last revision: > > Removed some duplicate code test/jdk/javax/swing/JFileChooser/JFileChooserSetLocationTest.java line 103: > 101: () -> pt.set(panel.getLocationOnScreen())); > 102: Point panel_loc = pt.get(); > 103: xIn = (panel_loc.x + panel.getSize().width) / 2; The getSize should be called on EDT as well. ------------- PR: https://git.openjdk.java.net/jdk/pull/7996
