On Thu, 5 May 2022 09:06:02 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

> > I am not sure if there is an y deterministic way to find out the location 
> > of the icon
> 
> Modified to use the capture area as used in the original webrev for Aqua 
> which will capture the title bar with icon 
> ![iconImage-fail](https://user-images.githubusercontent.com/43534309/166893097-8d64f43c-130f-4d31-838e-f03f6fab294f.png)
> 
> Capture area is modified slightly to omit the top inset too to remove the 
> blue background from captured image.
> 
> Testing in iMacs and other mac systems and other platforms are green.

The original issue was apart from ImageIcon all other`icon is displayed lower 
than it should be and to the right of where it should be, covering part of the 
title text.`
<img width="223" alt="Screenshot 2022-05-06 at 9 40 41 AM" 
src="https://user-images.githubusercontent.com/43534309/167071087-abf10d03-5026-4a90-849f-79c0c29e1ebb.png";>

whereas for ImageIcon
<img width="281" alt="Screenshot 2022-05-06 at 10 47 47 AM" 
src="https://user-images.githubusercontent.com/43534309/167071714-4a9dbafa-b739-4e28-9c44-900ffc1e91e7.png";>

so I think it should be ok testing the titlebar the bufferedimage with 
ImageIcon and Icon will be different thus testing the fix as well keeping all 
platforms happy

-------------

PR: https://git.openjdk.java.net/jdk/pull/8380

Reply via email to