On Tue, 17 May 2022 13:02:49 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
> Encapsulate the logic of adding or modifying a notification icon aka tray > icon. This is to avoid code duplication between > [`AwtTrayIcon::WmTaskbarCreated`](https://github.com/openjdk/jdk/blob/7b988b31c661c6e3e58cf8ced81732e40a79d4f5/src/java.desktop/windows/native/libawt/windows/awt_TrayIcon.cpp#L477) > and > [`AwtTrayIcon::_UpdateIcon`](https://github.com/openjdk/jdk/blob/7b988b31c661c6e3e58cf8ced81732e40a79d4f5/src/java.desktop/windows/native/libawt/windows/awt_TrayIcon.cpp#L796). > > Separating adding and modifying the icon simplifies the methods, the actions > are clearer: adding the icon requires sending `NIM_SETVERSION` message > whereas modifying the icon doesn't. > > To verify the code works as before, I used `TrayIconScalingTest.java`. I > killed explorer.exe process to verify the notification icon gets added. > Changing DPI of the main display updates the displayed icon as expected. Marked as reviewed by azvegint (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/8749
