On Fri, 20 May 2022 16:55:43 GMT, Alisen Chung <ach...@openjdk.org> wrote:

>> Changed the drawing area to be increased by 0.5 on the left side to prevent 
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   reverted copyright year

test/jdk/java/awt/EtchedBorder/ScaledEtchedBorderTest.java line 73:

> 71:     public static void main(String[] args) throws Exception {
> 72:         for (UIManager.LookAndFeelInfo laf : 
> UIManager.getInstalledLookAndFeels()) {
> 73:             SwingUtilities.invokeAndWait(() -> setLookAndFeel(laf));

I don't think there's a need to iterate over available Look-and-Feels, you use 
`EtchedBorder` directly. The default L&F or system L&F on each platform is 
enough.

test/jdk/java/awt/EtchedBorder/ScaledEtchedBorderTest.java line 201:

> 199:         }
> 200: 
> 201:         frame = new JFrame("Swing Test");

Don't you want to go frameless? It would make the test headless. In [this 
comment](https://github.com/openjdk/jdk/pull/7449#discussion_r878130575), I 
provided [sample 
code](https://github.com/alisenchung/jdk/compare/8279614...aivanov-jdk:alisen-8279614-titledBorder)
 which works without creating frame: just panels and borders.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7449

Reply via email to