On Fri, 20 May 2022 00:53:27 GMT, SWinxy <d...@openjdk.java.net> wrote:
>> The current implementation creates ~750 new objects on load, and uses a >> binary array search with a Comparable implementation. This implementation is >> probably bad. Instead, we can use the enhanced switch feature to possibly >> save time, resources, and code size. The new implementation means that the >> array doesn't have to be sorted alphanumerically necessarily, and it creates >> the colors on demand. > > SWinxy has updated the pull request incrementally with one additional commit > since the last revision: > > Accidental mergers. > > I created a quick check to see if any other colors were different (only > these three). For some odd reason "yellowgreen" and "yellow green" are > different. Do you have any numbers to compare possible performance improvements in lookupColor()? I'll assume it should be faster but can we prove that? ------------- PR: https://git.openjdk.java.net/jdk/pull/7096
