On Wed, 25 May 2022 11:56:47 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> This adds the Microsoft Basic Render Driver to our "bad hardware" list so 
>> that we don't use that pipeline there.
>> We have at least the one test that fails there and I am not sure we get any 
>> benefit from this.
>> I'm sure Microsoft need to provide for apps that have only a D3D option, but 
>> that isn't the JDK case.
>> 
>> FYI there was a PR a while back about problem listing that failing test : 
>> https://github.com/openjdk/jdk/pull/5930
>> but we don't need to do that with this change - nor worry about similar 
>> problems with other tests.
>
> src/java.desktop/windows/native/libawt/java2d/d3d/D3DBadHardware.h line 58:
> 
>> 56: 
>> 57:     // Microsoft Basic Render Driver (as maybe used in VMs such as 
>> VirtualBox)
>> 58:     { 0x1414, 0x008c, NO_VERSION, OS_ALL },
> 
> Any particular reason for not putting ALL_DEVICEIDS?

er, yeah, because it would be wrong. If Microsoft had a graphics card of their 
own, say in a Surface Pro,
all device ids would disable that too .. and I have no reason to do that 
without evidence that all MS drivers
for all theoretical MS hardware will have problems

-------------

PR: https://git.openjdk.java.net/jdk/pull/8797

Reply via email to