On Thu, 2 Jun 2022 06:03:16 GMT, Tejesh R <t...@openjdk.org> wrote:
>> The tooltip displays accelerated string along with the toooltip string. The
>> feature is implemented and applicable for Metal Look and Feel only. Hence
>> the test is updated for Metal Look and Feel by hard wiring it in the code.
>> Updated the test from manual to automatic.
>
> Tejesh R has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous content of the PR. The pull request contains one new
> commit since the last revision:
>
> Unused imports removed
test/jdk/javax/swing/JToolTip/bug5047379.java line 77:
> 75:
> 76: static void handleToolTip() throws Exception {
> 77: SwingUtilities.updateComponentTreeUI(frame);
This should be called on EDT, shouldn't it?
test/jdk/javax/swing/JToolTip/bug5047379.java line 88:
> 86: MetalToolTipUI toolTipObj = (MetalToolTipUI)
> MetalToolTipUI.createUI(tooltip);
> 87:
> 88: if (tooltip == null) {
Perhaps, the check for null should go before `createUI` with a null object?
test/jdk/javax/swing/JToolTip/bug5047379.java line 94:
> 92:
> 93: } catch (Exception e) {
> 94: throw new RuntimeException(e);
Do you expect any other exception but those you throw yourself to fail the test?
test/jdk/javax/swing/JToolTip/bug5047379.java line 133:
> 131: text += "ToolTip will appear. Here is what should show\t\t\n";
> 132: text += "The word \\\"TEXT\\\" and then \\\"CTRL-B\\\"\\n\"\t\t";
> 133: text += "\n";
Why are there two tabs in the end of each line.
Why can't you use static string concatenation? Or a text block?
Creating the string by `text += "literal"` isn't an efficient way.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8952
