On Tue, 7 Jun 2022 11:42:38 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JTableHeader/TableRendererTest.java line 31:
>
>> 29: @summary Test to check if table is printed without NPE
>> 30: @run main TableRendererTest
>> 31: */
>
> Could you move the test tags below the imports?
>
> Most new tests follow this style and I find it more convenient when viewing
> the test source in the IDE, the test tags aren't collapsed this way.
>
> Please add asterisk at the beginning of each line. It should look like this:
>
>
> /*
> * @test
> * @bug
> */
>
>
> To follow the common style of Java block comments and test tags in the
> majority of files.
>
> Please do not use `/**` as the first comment: it's not a Javadoc comment to
> avoid warning about the unknown javadoc tags.
Updated.
> test/jdk/javax/swing/JTableHeader/TableRendererTest.java line 47:
>
>> 45: import javax.swing.table.TableCellRenderer;
>> 46:
>> 47: public class TableRendererTest{
>
> I suggest making the name more specific: `TableHeaderRendererTest` or
> `TableHeaderRendererNPETest`.
Updated.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8830
