On Mon, 30 May 2022 01:15:01 GMT, Jeremy <d...@openjdk.java.net> wrote:

> Previously when you drew a line that moved exactly (+0, +0) with a miter 
> stroke the Stroker class acted like a horizontal miter was appropriate. Now 
> we abort instead, so no miter is applied.
> 
> The new unit test tests the original steps plus several variations.
> 
> I'm a little nervous about this change because it looks like someone 
> previously considered this exact condition and implemented a different 
> behavior. I don't think I understand the original rationale.

As mentioned in my code review, the stroker changes need one more condition: 
(prev == drawTo) return.

I tested this change and it fixes the bug's test code and your test code looks 
good.

Please update PR with the proposed change and we are good.

Deadline: tomorrow, sorry.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8943

Reply via email to