On Wed, 8 Jun 2022 17:18:20 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:

>> No, it didn't occur with "embedded" HTML. It occurred with your original 
>> version. I compiled the test and `PassFailJFrame` into `./build` directory 
>> (`javac -d ./build <java-files>` and then ran it `java -cp ./build 
>> HtmlTagParserTest`. Since I didn't set the `test.src` property, the HTML 
>> file was saved to the current directory but the class file was in another 
>> directory, `HtmlTagParserTest.class.getResource` pointed to a non-existent 
>> file.
>> 
>> However, now with the button… clicking the button would likely generate an 
>> exception too.
>
> I'll remove the button then as it's not necessary for the test. I mainly 
> added it to demonstrate that HTML contents are rendering correctly. I'll make 
> this change and update the doc for Parser to more explicitly explain what 
> happens when its editable vs non-editable.

It looks good overall.

It started with `<script>` tag; the text in javadoc refers to other unknown or 
unsupported tags. Shall the test be expanded with an unknown tag?

Displaying two instances of `JEditorPane` where one's editable and the other 
isn't could be too confusing. Only editable is enough, I guess.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7446

Reply via email to