On Fri, 10 Jun 2022 05:45:27 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
> This version look good, just one more thought. Can we extend this approach > and do not request all sizes if the user wanted only one image? So if the > user will request all images we request that list from the OS, otherwise only > one image will be requested and cached, what do you think? How would you implement this? I mean the user requests the icon in user's space (right?). On a High DPI system which may change in runtime, a larger icon version is required for rendering. To get a larger icon from native, we have to keep the file name or PIDL and call shell interfaces on COM thread to fetch the icon. Overall, I like the idea… We may have discussed it. Keeping only sizes that are needed will reduce the memory usage. All in all, it's definitely out of scope for this fix. ------------- PR: https://git.openjdk.org/jdk/pull/7805
