On Fri, 10 Jun 2022 09:29:01 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Test is failing in iMac CI systems owing to color difference of 1
>>
>> `x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0`
>>
>> Added minor color tolerance check. CI testing is green
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add color tolerance fix
Shall the copyright year be updated?
test/jdk/javax/swing/text/CSSBorder/6796710/bug6796710.java line 143:
> 141: int width = bufferedImage0.getWidth();
> 142: int height = bufferedImage0.getHeight();
> 143: int colorTolerance = 5;
A constant in the class?
test/jdk/javax/swing/text/CSSBorder/6796710/bug6796710.java line 167:
> 165: System.out.println("x "+ x + " y " + y +
> 166: " rgb1: " +
> Integer.toHexString(bufferedImage0.getRGB(x, y)) +
> 167: " rgb2: " +
> Integer.toHexString(bufferedImage1.getRGB(x, y)));
You can use the stored values in `bufCol0` and `bufCol1`.
test/jdk/javax/swing/text/CSSBorder/6796710/bug6796710.java line 182:
> 180:
> 181: return robot.createScreenCapture(rect);
> 182:
Could be removed?
-------------
Marked as reviewed by aivanov (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9011
