On Mon, 13 Jun 2022 22:35:41 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:

>> Fix history - #7422.
>> The test is automatic and check if the last row is painted (Which was not 
>> happening before the fix, the last row appeared only after MouseClick 
>> operation) by capturing the last row before and after MouseClick 
>> Operation.If the both the captured images are same, then the test passes 
>> else it fails.
>> This Fix includes for ubuntu and macos failure, in which only the test case 
>> failed due to following reasons.
>> 
>> In ubuntu, the test fails due to unexpected dark line appearing on right 
>> side of last row before MouseClick operation.
>> In macos, the test fails since after MouseClick operation of last row, 
>> clearSelection didn't show any effect on the selected row.
>> The issue is intermittent and not able to reproduce it frequently. As a 
>> defensive fix, the rectangular area which is being captured is reduce for 
>> ubuntu failure and Delay is added between ClearSelection of focus and Image 
>> Capture for macos failure
>
> test/jdk/javax/swing/JTable/8236907/LastVisibleRow.java line 172:
> 
>> 170:                 SwingUtilities.convertPointToScreen(point, table);
>> 171: 
>> 172:                 captureRect[0] = new Rectangle(point.x+5, point.y+2, 
>> table.getColumnCount() * cellRect.width - 10, cellRect.height-2);
> 
> Please adjust line lengths. Some of the lines contain more than 80 characters.

Updated.

-------------

PR: https://git.openjdk.org/jdk/pull/9117

Reply via email to