On Fri, 10 Jun 2022 06:02:51 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor changes > > src/java.desktop/windows/native/libawt/windows/awt_Window.cpp line 1407: > >> 1405: int extraPaddedBorderInsets = info.dwMajorVersion >= 6 ? >> 1406: ::GetSystemMetrics(SM_CXPADDEDBORDER) : 0; >> 1407: > > The OS version check is added since **SM_CXPADDEDBORDER** metric is not > supported on Win XP & 2000. If the current JDK Window target OS version is > set to Windows Vista, probably this check is not required or redundant. > Suggestions would be helpful as to whether to retain this check or not > >  > > Screenshot source: [GetSystemMetrics > Doc](https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getsystemmetrics) You can look at the oficially supported versions of operating systems by different Java versions here: https://www.oracle.com/java/technologies/javase-subscription/documentation.html#sysconfig Nothing even remotely relevant supports Windows XP. ------------- PR: https://git.openjdk.org/jdk/pull/9118