On Tue, 28 Jun 2022 06:40:41 GMT, Sergey Bylokhov <[email protected]> wrote:
>>> That's not a mistake, the swing was updated in a few places here and there >>> to support it, for example: https://bugs.openjdk.org/browse/JDK-8194873 >> >> I dont think @prrace and me are contesting need of ALT_GRAPH in swing, which >> was fixed by the above bug..I guess it was being contested for macos only so >> we are not going to revert 8194873 but only 8151136 (which was done to >> convert right alt to altgraph for macos) > > That is similar issue on Windows since we unconditionally set the right alt > key to be ALT_GRAPH independently of the current keyboard layout, it is just > a button location which is the same on win and mac. So probably right now it > is better to update the spec of that flag. > > To workaround that change the fix for > [JDK-8194873](https://bugs.openjdk.org/browse/JDK-8194873) updated all our > L&F which are used on windows, obviously the Aqua was missed. I think we > should update the Aqua in a similar way. I can see "AltGr" key in windows keyboard but not mac so am not sure why should we support just because of key location. Anyway, I will let @prrace decide on that. If we need to support altgr, then present PR supports both 8151136 (alt graph) and also Right/Left Option Up/Down ------------- PR: https://git.openjdk.org/jdk/pull/9230
