On Wed, 29 Jun 2022 00:53:08 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Manukumar V S has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments fixed: Removed -Dsun.java2d.uiScale=1,
>> frame.getLocationOnScreen() removed from EDT, added volatile keyword for
>> actionEventReceivedLatch
>
> test/jdk/java/awt/PopupMenu/PopupMenuLocation.java line 69:
>
>> 67: GraphicsConfiguration gc = sd.getDefaultConfiguration();
>> 68: Rectangle bounds = gc.getBounds();
>> 69: Point point = new Point(bounds.x + 20, bounds.y + 20);
>
> Why do you need to add this additional 20 pixels? When we click on the frame
> we already shift the mouse click location by 130 pixels from the top of the
> frame.
Reverted it
> test/jdk/java/awt/PopupMenu/PopupMenuLocation.java line 119:
>
>> 117: private static void openPopup(final Frame frame) throws Exception {
>> 118: robot.waitForIdle();
>> 119: Point loc = frame.getLocationOnScreen();
>
> Since you removed the reading the location from EDT via a separate loc
> variable, you do not need to rename pt here? The only meaningful change is
> adding the CountDownLatch?
Reverted it
-------------
PR: https://git.openjdk.org/jdk/pull/9187
