On Thu, 30 Jun 2022 00:09:27 GMT, Harshitha Onkar <[email protected]> wrote:
>> Previously frame.pack() was called twice as a workaround AWT frame sizing >> issue in this particular test case on Windows. This issue was fixed >> **[JDK-8265586](https://bugs.openjdk.org/browse/JDK-8265586)** and hence the >> workaround is being removed from this test. >> >> PassFailJFrame is being used as the test framework. >> >> **Proposed change related to PassFailJFrame Test framework** >> >> Instead of creating separate methods to handle AWT Windows as well as >> Frames, method signatures - >> [**PassFailJFrame.positionTestFrame()**](https://github.com/openjdk/jdk/blob/53b37fe1535388eb14e04c620a6b0118ed8884a0/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java#L271) >> and >> [**PassFailJFrame.addTestFrame()**](https://github.com/openjdk/jdk/blob/53b37fe1535388eb14e04c620a6b0118ed8884a0/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java#L294) >> can be changed to take in Window as input parameter instead of Frame, since >> Window is a superclass, this would allow the test frame to be a >> Window/Frame/Dialog and not be restricted to a Frame, additionally would >> allow proper disposal of windows added to the PassFailJFrame. >> >> **Above PassFailJFrame changes tracked by: >> [JDK-8289238](https://bugs.openjdk.org/browse/JDK-8289238)** > > Harshitha Onkar has updated the pull request incrementally with one > additional commit since the last revision: > > PassFailJFrame changes Looks good. ------------- Marked as reviewed by azvegint (Reviewer). PR: https://git.openjdk.org/jdk/pull/9286
