On Wed, 29 Jun 2022 08:28:20 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> Test seems to fail in macOS citing popup location is 1 pixel off compared to > combobox position ie > `p.y 154 cpos.y 155` > > But in macOS, popup location, if 1st entry is selected, is 1 pixel higher > than combobox so it's expected as can be seen below > <img width="661" alt="Screenshot 2022-06-29 at 1 53 42 PM" > src="https://user-images.githubusercontent.com/43534309/176389227-4e568117-ffce-4b4a-92d7-ab5c78c4ce08.png";> > > so test is updated to add 1 pixel to popup location. > It will not affect windows and linux as popup is placed below the combobox in > those platforms so 1 pixel higher will not make any difference. > Also, added some stability fixes..Test passed for several iterations in all > platforms in CI.. This pull request has now been integrated. Changeset: 649f2d88 Author: Prasanta Sadhukhan <psadhuk...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/649f2d8835027128c6c8cf37236808094a12a35f Stats: 131 lines in 2 files changed: 37 ins; 4 del; 90 mod 8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off Reviewed-by: aivanov ------------- PR: https://git.openjdk.org/jdk/pull/9321
![https://user-images.githubusercontent.com/43534309/176389227-4e568117-ffce-4b4a-92d7-ab5c78c4ce08.png"](https://user-images.githubusercontent.com/43534309/176389227-4e568117-ffce-4b4a-92d7-ab5c78c4ce08.png"){kind=link}