On Wed, 6 Jul 2022 11:59:31 GMT, Abhishek Kumar <d...@openjdk.org> wrote:

>> JFileChooser - empty file size issue fixed. 
>> For empty file, now the size 0 bytes.
>> Manual Test Case "ZeroFileSizeCheck.java" created.
>
> Abhishek Kumar has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Byte entry added to basic.properties, MessageFormat used to format file 
> length

src/java.desktop/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties
 line 80:

> 78: 
> 79: # File Size Units
> 80: FileChooser.fileSizeBytes={0} bytes

should it be "{0} B" to be consistent with the rest of the formatting strings?

src/java.desktop/share/classes/sun/swing/FilePane.java line 532:

> 530:                         
> UIManager.getString("FileChooser.detailsViewActionLabelText", l);
> 531: 
> 532:         byteString      = 
> UIManager.getString("FileChooser.fileSizeBytes", l);

is the '-' character misaligned or is this a github rendering artifact?

-------------

PR: https://git.openjdk.org/jdk/pull/9327

Reply via email to