On Wed, 10 Aug 2022 05:30:56 GMT, Abhishek Kumar <d...@openjdk.org> wrote:
>> JFileChooser - empty file size issue fixed. >> For empty file, now the size 0 KB. >> Manual Test Case "FileSizeCheck.java" created. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > updated as per review comments >> If we display the file size with one decimal point precision, then it >> doesn't hold at all until the file size reaches 1 KB. Is your point ( pun intended) that it looks like we are displaying files to a decimal precision, but in fact are not ? ie it is very odd to display 1.0kb for files of 100, 200, 300, etc bytes .. What is the reason for displaying them all as 1.0kb .. this review is so long I'm not sure I am following any more. Could we get a summary in a few sentences of the entire current proposal and the justification for it ? ------------- PR: https://git.openjdk.org/jdk/pull/9327
