On Wed, 3 Aug 2022 05:59:34 GMT, Alan Bateman <[email protected]> wrote:
>>> One other comment on this is that the proposed change should mean that the >>> tests no longer need to run with --enable-preview. >> >> You've lost me all over again. >> Why did these two tests need that in the first place and why would they no >> longer need it ? >> >> My best guess is that it was added so that the tests deliberately provoked >> using continuations to verify everything worked but that with the change >> there's no point since it won't load any classes that use them .. ? > >> My best guess is that it was added so that the tests deliberately provoked >> using continuations to verify everything worked but that with the change >> there's no point since it won't load any classes that use them .. ? > > That's right. These tests triggered the initialization of classes that depend > on the VM being started with --enable-preview. With the proposed change here, > the classes will be loaded but not initialized so it won't execute code that > needs preview features to be enabled. > Thanks, @AlanBateman ! Let's wait and see if @prrace approves the change. I didn't see any more from @prrace. If you don't get a response in the next day or so then I would suggest just integrating this. It will help others that are testing ports that don't have the VM continuation support at this time. ------------- PR: https://git.openjdk.org/jdk/pull/9704
