On Wed, 17 Aug 2022 11:48:21 GMT, Tejesh R <[email protected]> wrote: >> The Document for _DefaultStyledDocument.setCharacterAttribute_ states that >> the range of length accepted is `length - the length >= 0`, whereas in code >> the length check is done only for `length==0`. Meaning the control just >> returns if the `length` is 0. Since length is _int_ type and there is a >> possibility of negative length being set through the method, the code >> doesn't actually handles the negative length case. Hence to handle negative >> length, negative length check has been added along with 0 check. Its safe to >> check and return the control for `negative` length input. Test case to check >> the same is added. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Updated based on review comments
Although I've reviewed the CSR I'd prefer it not be finalized yet. I think it needs more changes. The spec is SILENT about what then happens if length is negative and SILENT about an out of range offset too. I think we should address these issues as well. Also everywhere - in the CSR and the bug description and summary the text said the method is called setCharacterAttribute whereas it is setCharacterAttributes. ------------- PR: https://git.openjdk.org/jdk/pull/9830
