On Wed, 7 Sep 2022 22:33:17 GMT, lawrence.andrews <d...@openjdk.org> wrote:
>> 1) This test was failing due to yesno >> test result: Error. Parse Exception: Arguments to `manual' option not >> supported: yesno >> 2) PrintCheckboxManualTest.html file was missing >> 3) Added os.family since test instruction says that its a linux and solair >> toolkit only test >> 4) Removed Sysout & TestDialog class & added a better manual framework to >> show the instruction and test frame. >> >> @shurymury > > lawrence.andrews has updated the pull request incrementally with one > additional commit since the last revision: > > Fixed space issue test/jdk/java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java line 69: > 67: > 68: String instruction = """ > 69: Linux or Solaris with XToolkit ONLY! since there already is @requires (os.family == "linux" | os.family == "solaris") is this line needed? Can there be anything else besides XToolkit on linux or solaris? If yes, is there a way to determine that programmatically? If no, how does user finds that out? Lastly, what is the test executor supposed to do if it is not XToolkit on linux or solaris? ------------- PR: https://git.openjdk.org/jdk/pull/9858
