On Fri, 9 Sep 2022 04:35:15 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> It will have the problem as you mentioned so I did it as it is. Since we >> have already UIDefaults table defined, I think it can be used for this, >> without changing the doc which might cause compatibility issues. > > it will also probably need change in compiler as to how it generates/parses > the type as I am getting > > Exception in thread "main" java.lang.NullPointerException: Cannot invoke > "build.tools.generatenimbus.UIProperty$PropertyType.ordinal()" because > "this.type" is null > at build.tools.generatenimbus.UIProperty.write(UIProperty.java:87) > at build.tools.generatenimbus.UIStyle.write(UIStyle.java:156) > at build.tools.generatenimbus.UIRegion.write(UIRegion.java:213) > at build.tools.generatenimbus.SynthModel.write(SynthModel.java:102) > at build.tools.generatenimbus.Generator.generate(Generator.java:212) > at build.tools.generatenimbus.Generator.main(Generator.java:118) > > so I think this is the safer and cleaner alternative as I am not creating a > new UIDefaults table, just adding a new entry to it.. It is probably simpler but we already store all tha properties in the generated NimbusDefaults, I do not think we should split the storage in two parts. ------------- PR: https://git.openjdk.org/jdk/pull/10035
