On Wed, 14 Sep 2022 16:27:36 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

> Add `forceFail` implementation which allows passing the reason why the test 
> is failed.
> 
> I used the newly added method `forceFail(reason)` instead of throwing an 
> exception in `PrintAllPagesTest`. When the test is run outside of jtreg and 
> printing is cancelled, the the test UI becomes “hung”: clicking Pass or Fail 
> or closing windows does not stop the test.
> 
> I also converted the `ret` field to local variable.
> 
> In addition to this, I reduced the size of the test frame, its size of 
> 1000×800 doesn't fit even full HD screens when positioned close to the 
> instruction frame.

Addition of reason to force fail test makes it more clear. Changes look good.

-------------

Marked as reviewed by honkar (Author).

PR: https://git.openjdk.org/jdk/pull/10269

Reply via email to