On Mon, 19 Sep 2022 18:10:22 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> ScientificWare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Corrects typos and digit extraction.
>>
>> Corrects typos.
>> And applies a better digit extraction as suggested in main-line review
>> thread.
>
> test/jdk/javax/swing/text/html/CSS/Hex3468DigitsColor.java line 71:
>
>> 69: alpha = color.getAlpha();
>> 70: result.append("\n Test for #ff1122aa");
>> 71: if (red != 255) {
>
> `red`, `green` and `blue` haven't changed here. You may want to get them from
> the `color` object.
>
> Alternatively, you can compare the RGB:
>
> if (0xaaff1122 != color.getRGB()) {
> // fail the test
> }
I'm going to work on rgb() and rgba() notations
(https://bugs.openjdk.org/browse/JDK-8294090). Could we let this unchanged or
differ this change ?
-------------
PR: https://git.openjdk.org/jdk/pull/10317
