On Mon, 26 Sep 2022 06:45:58 GMT, Jayathirth D V <[email protected]> wrote:
> This is redo of https://bugs.openjdk.org/browse/JDK-8262297 > In https://bugs.openjdk.org/browse/JDK-8262297 we added similar change but we > didnt allow 15bpp image in BMP, because of which many tests which were using > USHORT_555_RGB format were failing as reported at > https://bugs.openjdk.org/browse/JDK-8278047 > > There is ambiguity on whether we should support 15bpp BMP encoding also or > not as captured in JBS : > https://bugs.openjdk.org/browse/JDK-8278086?focusedCommentId=14521952&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14521952 > > Since adding tighter condition to only allow 0, 1, 4, 8, 16, 24 and 32 bpp is > causing many failures. I have modified the check to allow 15bpp also. src/java.desktop/share/classes/com/sun/imageio/plugins/bmp/BMPImageWriter.java line 1458: > 1456: return false; > 1457: } > 1458: int biType = imgType.getBufferedImageType(); Can remove biType variable I guess, since its not been used. The fix is tested and verified. ------------- PR: https://git.openjdk.org/jdk/pull/10419
