On Mon, 3 Oct 2022 21:18:55 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> removed redundant jtreg header > > src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java line > 313: > >> 311: >> 312: // border and corner scaling >> 313: int scaledCorner = (int) Math.round(corner * >> at.getScaleX()); > > Just a suggestion, you can call this variable `corner` but make the constant > above upper case `CORNER`. This way the old code would remain basically the > same and continue using `corner` (which was previously a field). Updated > test/jdk/javax/swing/JInternalFrame/InternalFrameBorderTest.java line 211: > >> 209: + cornerLocation); >> 210: } >> 211: robot.mouseMove(x, y); > > Moving the mouse cursor is not required. However, it gives a visual feedback > of where the check is happening. @aivanov-jdk I have retained the mouseMove for visual confirmation ------------- PR: https://git.openjdk.org/jdk/pull/10274
