On Wed, 5 Oct 2022 21:00:11 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:

>> JInternalFrame background color seems to overflow into the border region. 
>> This issue is more prominently seen on Windows - Metal LAF (with fractional 
>> scaling, as shown below). The primary reason is border scaling issue as 
>> observed in - [JDK-8279614](https://bugs.openjdk.org/browse/JDK-8279614) 
>> 
>> The fix involves a similar approach as described here 
>> https://github.com/openjdk/jdk/pull/7449#issuecomment-1068218648. The test 
>> checks the midpoint and corners of borders to check if the internal frame's 
>> background color is located out of JInternalFrame.
>> 
>> ![image](https://user-images.githubusercontent.com/95945681/190233555-a7e00f2c-9003-4c11-84fb-207957838c2f.png)
>
> Harshitha Onkar has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   test updated

Two edge cases issues were identified while testing with different frame sizes 
and on different platforms-

- One was due to the inherent issue of robot.getPixelColor() which sometimes 
returns a different pixel color returned at the edge of border. This is a test 
issue and is fixed by adding a offset of 1 pixel to the border and corner 
checks.

- The other issue occurs only in specific scenario - when the internal frame 
size is set to 125, 150, 225, 250...etc on uiScale of 1.25 (on Windows). A thin 
red line is seen at the bottom of the border. This is might be due the 
`loopCount` value.

-------------

PR: https://git.openjdk.org/jdk/pull/10274

Reply via email to