On Mon, 26 Sep 2022 14:05:04 GMT, Jayathirth D V <[email protected]> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Comment added and test case condotion update
>
> What is the behaviour in other LAF's?
> Also lets change title of this bug to something like "GTK L&F: JFileChooser
> can jump beyond root directory in combobox and selection textarea"
@jayathirthrao @TejeshR13 As compared to previous fix where the condition was
handled at listener level (mouse double click event), has been changed in
current fix.
Now as per the current fix the proposed solution is to remove the "../" from
directory list if the current directory is root in GTK LAF.
Test case has been updated to manual test as compared to previous fix.
CI link is added in JBS for latest commit.
> test/jdk/javax/swing/JFileChooser/TestFileChooserDirectorySelection.java line
> 102:
>
>> 100:
>> 101: private static void doubleClickMouse(Point p) {
>> 102: robot.mouseMove(p.x+75, p.y+frame.getHeight()/2 - 90);
>
> We should not use magic numbers to determine location on screen. Will these
> coordinates hold true at different uiScales?
Test case has been changed to manual now. So, there is no need of getting
location on screen now.
-------------
PR: https://git.openjdk.org/jdk/pull/10390
