On Wed, 28 Sep 2022 12:42:14 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> CheckBox.disabledText and RadioButton.disabledText color UIProperty is not >> honoured by Nimbus L&F when disabled text is drawn for JCheckBox and >> JRadioButton, so disabled text color was rendered incorrectly. >> Fix is to honour these UIProperty color if they are set by user, else use >> the color from the component or via getColorForState(). >> >> Closed test as mentioned in JBS is used to check the fix. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Test fix The spec for the changed method mention that the "getColorForState" should be called for the component if the app did not specify the color explicetly. Should the fix do the same instead of direct call of "UIManager.getColor"? And if it does not work should we updated the skin to include these props? ------------- PR: https://git.openjdk.org/jdk/pull/10177
