On Wed, 19 Oct 2022 07:13:44 GMT, Abhishek Kumar <[email protected]> wrote:

>> Existing test 
>> `open/test/jdk/javax/swing/JRadioButton/4314194/bug4314194.java` was not 
>> showing colored text for disabled checkbox and radiobutton in GTK LAF.
>> 
>> The fix is to get the disabled state color for checkbox and radiobutton from 
>> UIManager if it exists. 
>> 
>> Test case `open/test/jdk/javax/swing/JRadioButton/4314194/bug4314194.java` 
>> has been checked in CI pipeline. Link is attached in JBS.
>
> Abhishek Kumar has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains three commits:
> 
>  - ProblemList.txt file merge resolved
>  - 8295006 entry removed from problem lists
>  - Fix for disabled checkbox and radiobutton colored text

As per 
https://docs.oracle.com/en/java/javase/19/docs/api/java.desktop/javax/swing/plaf/nimbus/package-summary.html
it seems UIDefaults (ie UIManager.getDefaults) should be honoured first which 
can be overridden by altering the table via UIManager.put. There's also client 
property named "Nimbus.Overrides" which override the UIManager settings, so as 
I interpret it the UIManager.getDefaults() should be honoured unless it is 
overridden by Nimbus.Overrides which was not the case in my fix.

-------------

PR: https://git.openjdk.org/jdk/pull/10755

Reply via email to