On Mon, 31 Oct 2022 09:11:21 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> If getDefaultEditor() is called before the JTable model is setup, it results 
>> in NPE.
>> 
>> This is because when JTable sets its model, which ends up firing a table 
>> changed event. The testcase is listening for tableChanged events and 
>> querying the editor. But the editor isn't installed until after the model is 
>> set which results in NPE.
>> Fix is to ensure initializeLocalVars() which initializes default editor is 
>> setup before JTable sets its model.
>> 
>> No regression is observed in jtreg/jck testsuite with this change.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Review fix

test/jdk/javax/swing/JTable/JTableEditorNPE.java line 83:

> 81:                 resizeAll();
> 82:             }
> 83:             else {

Suggestion:

            } else {

-------------

PR: https://git.openjdk.org/jdk/pull/10871

Reply via email to