On Sun, 13 Nov 2022 08:25:57 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
> > could you use `jio_snprintf` instead (see include/jvm_io.h)? That is what > > we usually do for snprintf. jio_snprintf hides platform particularities wrt > > snprintf. > > Good to know that. Thank you! > > While I was doing the replacement from `snprintf` to `jio_snprintf`, I > noticed a lot of existing use of `snprintf` in the files touched in this PR. > What do you think if we have a `snprintf` clean up in a followed PR? > > ``` > hotspot $ find . -type f |xargs grep snprintf |grep -v jio_snprintf |wc > > 262 1895 26574 > ``` Hmm, possibly. We may look again at the exact reason why we use jio_snprintf. Maybe it is less important nowadays, with reduced platform number (no solaris) and Windows being more standard conform than it had been in the past. Lets hear what others think. ------------- PR: https://git.openjdk.org/jdk/pull/11115
